You need to escape the script properly to post it in a comment (although a public URL where it can be viewwd is much more preferable).

Either way, you should really be using a later version of the script.

SCRIPT

BUT I DON’T SEE IT POSTED. MY SITE IS STILL IN MY DOCUMENTS FOLDER.

I really can’t say why the rest of your code doesn’t work, especially not when I can’t see it. This function works to select elements with a certain class.

To be able to even have a chance to say what’s wrong, you need to post a URL to where I can see your code in action.

Thanks!

This function does not add anything to an element, it’s just a way to select them.

About your problems with IE: my guess is that you have called the function through document.getElementsByClassName, and not getElemenetsByClassName, so you don’t get any references back to the element.

If you have a URL to a sample, please add it here.

Start by using the new version, linked to at the top of this page. If it fails, please provide a URL to a test page.

This is part of the span code I want to alternately show/ hide.
Sorry about not paying attention to the HTML instructions

var myBrowserVersion;
myBrowserVersion = parseInt(BrowserDetect.version);
//Detect if visitor is using Firefox 2 (less that version 3)
//If so just use a mailto method to send email.
//Otherwise use the abuse form

if (BrowserDetect.browser == “Firefox”){
//BrowserDetect.browser == “Firefox” && myBrowserVersion < 3
var badBrowser = getElementsByClassName(“bad-Browser”);
for(i = 0; i < badBrowser.length; i++) {
badBrowser.style.display = “none”;
goodBrowser.style.display = “block”;
}

}else {
var goodBrowser = getElementsByClassName(“good-Browser”);
for(i = 0; i < goodBrowser.length; i++) {
badBrowser.style.display = “block”;
goodBrowser.style.display = “none”;
}

}

Report abuse
Report Abuse

My initial feedback would be that you shouldn’t overwrite the native document.getElementsByClassName in web browsers if it already exists, but rather utilize it.

i’ve wrote an getElementsByClassName too.
Are there any improvement suggestions?

you can call it these ways:
var myObj = document.getElementsByClassName(['foo', 'bar'], ‘a’);
var myObj = document.getElementsByClassName(['foo', 'bar']);
var myObj = document.getElementsByClassName(‘foo’, ‘a’);
var myObj = document.getElementsByClassName(‘foo’);

document.getElementsByClassName = function(cl,elem){
var elementsByClassName = [];
var regExpString = ”;

if(typeof(elem) == ‘undefined’) elem = ‘*’;

if(typeof(cl) == ‘object’){
var countOfCl = cl.length;
var OR = “|”;

for(var k=0; k < cl.length; k++){
countOfCl–;
if(countOfCl == 0) OR = ”;

regExpString += ‘\\b’+cl[k]+’\\b’+OR;
}
}else{
regExpString = ‘\\b’+cl+’\\b’;
}

var regExpString = new RegExp(regExpString);

var elements = this.getElementsByTagName(elem);
for (var i = 0; i < elements.length; i++) {
var className = elements[i].className;
if (regExpString.test(className)) elementsByClassName.push(elements[i]);
}

return elementsByClassName;
};

Greetings from Berlin
toni